Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSValueArgumentImpl checks equality using KSName.equals, which isn't implemented #2090

Open
ZacSweers opened this issue Sep 7, 2024 · 0 comments
Open

KSValueArgumentImpl checks equality using KSName.equals, which isn't implemented #2090

ZacSweers opened this issue Sep 7, 2024 · 0 comments

Comments

@ZacSweers
Copy link
Contributor

While trying to debug why annotation argument equality wasn't working in a processor, I was surprised to find the KSValueArgumentImpl does a name == other.name, as KSName doesn't implement equality. It may work sometimes for instance check if the name was computed from Resolver.getKSName(), but it seems error-prone at best.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZacSweers