Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more 0.5.x release? #844

Closed
hauntsaninja opened this issue Jan 2, 2025 · 4 comments
Closed

One more 0.5.x release? #844

hauntsaninja opened this issue Jan 2, 2025 · 4 comments

Comments

@hauntsaninja
Copy link
Contributor

Given 0.6 has several changes (see #798 (comment) ), it would be nice if magika could make another 0.5 release including #591

@reyammer
Copy link
Collaborator

Hello @hauntsaninja, (happy new year!). That's a good idea. We may have a new (faster) model for 0.6.x so we may postpone a bit more to allow for more testing.

Any other changes you think would be good to include in a new 0.5.x release?

@reyammer
Copy link
Collaborator

More thoughts on this: I just remembered that I did try to fix #591 for the 0.5.x versions, but at the time we were still relying on poetry, and poetry had issues with it (see the discussion in #591 itself). So, unclear what would be beneficial to include in another 0.5.x version. And it would be relatively tricky, as we would need to pick up again whatever release pipeline we had pre poetry => uv migration, with likely many details I have forgotten about.

That being said, we mainly heard two concerns about the new 0.6.x version:

  1. increased inference time. standard_v2_1 was indeed slower than standard_v1. However, we made progress on this aspect, and the upcoming standard_v3_0 should be even faster than standard_v1 (see Start using standard_v3_0 in rust CLI & test #868 and Start using standard_v3_0 in rust CLI & test #868 for more context).

  2. the python package is not pure python anymore. This is indeed annoying, but having an actual binary CLI (with no python-related bootstrap overhead has its significant advantages). A discussion on potential alternative is here: Discussion on having a source distribution that is pure python #870.

Any feedback is appreciated!

@reyammer
Copy link
Collaborator

Hello again!

we just released a new -rc version, which other than shipping the latest rust client and the last model (which should be ~3x faster than standard_v2_1 and 20% faster than standard_v1), is also available as a pure-python wheel for platforms we don't support yet with rust.

https://pypi.org/project/magika/0.6.1rc0/

See details in the changelog.

You should be able to install and test with pip install --pre magika.

This should address the two concerns we heard about the new version: 1) slower inference speed (now fixed), and 2) the new wheels were not pure-python anymore, limiting the potential install base. With all this done, I believe a new version for 0.5.x should be less critical.

If you think that would still be beneficial, let us know, we are happy to work through any issues you may encounter :-)

Thanks!

@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented Jan 26, 2025

Sorry, been a little busy. But that sounds great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants