Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List needs sizing and color changes to match spec #4056

Closed
Garbee opened this issue Feb 1, 2016 · 2 comments
Closed

List needs sizing and color changes to match spec #4056

Garbee opened this issue Feb 1, 2016 · 2 comments
Assignees

Comments

@Garbee
Copy link
Collaborator

Garbee commented Feb 1, 2016

The line height makes the text very squished for 3-line list items. The spec (ref: "Three line lists" section) shows there should be more spacing around the text giving a good level of whitespace.

Investigate whether something is off in typography or with the line-height itself here.

@sgomes
Copy link
Contributor

sgomes commented Feb 2, 2016

Looking at this, a lot of the numbers in lists are wrong, not just the line height. I'm taking a pass through the whole thing.

@Garbee
Copy link
Collaborator Author

Garbee commented Feb 2, 2016

Really? Most of them seemed right on my pass through. The only problem was the font weight made me think that stuff was right when it wasn't.

Maybe something got mixed up in the update to drop the mixin that was being used. I didn't do a run-through after that since it looked the same.

@sgomes sgomes changed the title Line-height on 3-line lists is off List needs sizing and color changes to match spec Feb 3, 2016
@sgomes sgomes closed this as completed in 2f58068 Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants