Skip extracting whitespace-only messages #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
force-pushed
the
skip-empty-messages
branch
8 times, most recently
from
dd12327
to
af19f55
Compare
|
With this, we can now extract messages from the Rust Book and the second commits implements a test for this! |
dyoo
approved these changes
Nov 7, 2023
This skips empty messages and messages consisting of whitespace only. Fixes #64.
This did not work before because we produced many duplicate `""` messages.
mgeisler
force-pushed
the
skip-empty-messages
branch
from
af19f55
to
9ad25f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips empty messages and messages consisting of whitespace only.
Fixes #64.