Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove fastify as a dependency. #7

Closed
mcollina opened this issue Feb 1, 2018 · 3 comments
Closed

remove fastify as a dependency. #7

mcollina opened this issue Feb 1, 2018 · 3 comments

Comments

@mcollina
Copy link
Contributor

mcollina commented Feb 1, 2018

as titled
@jinwoo
Copy link
Member

jinwoo commented Feb 3, 2018

Why is this a problem? fastify is a dependency only for the type information, and it'll be removed from the transpiled JavaScript files.

@mcollina
Copy link
Contributor Author

mcollina commented Feb 4, 2018

It still is a dependency downloaded from npm. You should move it to devDependencies.

@jinwoo jinwoo mentioned this issue Feb 5, 2018
Merged
@jinwoo
Copy link
Member

jinwoo commented Feb 5, 2018

#8 addresses this. I know it conflicts with #6. I will redo and merge #8 only after #6 is merged.

@jinwoo jinwoo closed this as completed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @jinwoo