Remove thread state change callstack feature flag #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the feature flag for callstacks on thread state changes. Test: Local Bug: http://b/235554760
dpallotti
approved these changes
Oct 4, 2022
src/OrbitQt/orbitmainwindow.cpp
Outdated
| } | ||
|
|
||
| uint16_t stack_dump_size = static_cast<uint16_t>( |
There was a problem hiding this comment.
thread_state_change_stack_dump_size to not confuse with the one for sampling.
karupayun
approved these changes
Oct 4, 2022
| .value(kThreadStateChangeCallstackMaxCopyRawStackSizeSettingKey, | ||
| orbit_qt::CaptureOptionsDialog::kThreadStateChangeMaxCopyRawStackSizeDefaultValue) | ||
| .toUInt()); | ||
| app_->SetThreadStateChangeCallstackStackDumpSize(stack_dump_size); |
There was a problem hiding this comment.
We were setting the stack_dump_size as max before in case of unspecified callstack collection. I guess that this doesn't matter at all in this case, since it will be ignored, but could we have a potential issue because unespecified value?
There was a problem hiding this comment.
Yeah, that shouldn't be an issue. That value is ignored in that case anyways.
florian-kuebler
deleted the
feature/release_thread_state_change_callstacks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the feature flag for callstacks on thread state changes.
Test: Local
Bug: http://b/235554760