Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that package exists in affected property #1055

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jun 21, 2024

This has always been allowed by the spec but now there's at least one real-world advisory in the Debian database like this which causes it to error.

@G-Rath
Copy link
Collaborator Author

G-Rath commented Jun 21, 2024

This unbreaks #958

@G-Rath G-Rath force-pushed the generators/ensure-package-present branch from 53e3404 to 8a4f342 Compare June 21, 2024 21:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@46aee59). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1055   +/-   ##
=======================================
  Coverage        ?   65.30%           
=======================================
  Files           ?      150           
  Lines           ?    12525           
  Branches        ?        0           
=======================================
  Hits            ?     8179           
  Misses          ?     3882           
  Partials        ?      464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath marked this pull request as ready for review June 21, 2024 21:57
@another-rex another-rex merged commit fdca369 into google:main Jun 25, 2024
13 checks passed
@G-Rath G-Rath deleted the generators/ensure-package-present branch June 25, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants