Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guided remediation): Add FIXED-VULN-IDS to non-interactive output #1210

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

michaelkedar
Copy link
Member

Closes #1203
Add a FIXED-VULN-IDS: line to non-interactive guided remediation output, which is a comma-separated list of the IDs of the vulnerability resolved, in alphabetical order.

@michaelkedar michaelkedar added the guided remediation Related to guided remediation / osv-scanner fix label Aug 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.95%. Comparing base (35b36a3) to head (6200dbf).
Report is 10 commits behind head on main.

Files Patch % Lines
cmd/osv-scanner/fix/noninteractive.go 96.07% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1210      +/-   ##
==========================================
+ Coverage   65.89%   65.95%   +0.05%     
==========================================
  Files         168      168              
  Lines       14072    14147      +75     
==========================================
+ Hits         9273     9330      +57     
- Misses       4289     4301      +12     
- Partials      510      516       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there are also changes other than FIXED-VULN-IDS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I regenerated the whole output, and there are some new vulns since I initially generated them.

@michaelkedar michaelkedar merged commit 66ec99b into google:main Aug 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guided remediation Related to guided remediation / osv-scanner fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osv-scanner fix should output the vulnerabilities fixed by the updates
3 participants