fix: output invalid PURLs when scanning sboms #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
report-invalid-purls
branch
from
04f9486
to
9d6d78b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
+ Coverage 68.43% 68.53% +0.10%
==========================================
Files 175 175
Lines 16798 16804 +6
==========================================
+ Hits 11495 11516 +21
+ Misses 4673 4661 -12
+ Partials 630 627 -3 ☔ View full report in Codecov by Sentry. |
cuixq
approved these changes
Sep 30, 2024
hogo6002
approved these changes
Sep 30, 2024
G-Rath
force-pushed
the
report-invalid-purls
branch
from
9d6d78b
to
462044a
Compare
another-rex
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I believe such situations indicate a bug in the tool used to generate the SBOM, outputting the PURLs should make it easier to debug the issue.
Resolves #86