Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that vulnerability results are ordered deterministically #220

Merged
merged 1 commit into from
Feb 20, 2023
Merged

fix: ensure that vulnerability results are ordered deterministically #220

merged 1 commit into from
Feb 20, 2023

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Feb 17, 2023

Resolves #182

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just suggested adding another test with the orders swapped.

cmd/osv-scanner/main_test.go Show resolved Hide resolved
@another-rex another-rex merged commit 435eda0 into google:main Feb 20, 2023
@G-Rath G-Rath deleted the make-output-deterministic branch February 21, 2023 18:49
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make output ordering deterministic
2 participants