Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PNPM v6+ Lockfile #325

Merged
merged 8 commits into from
Apr 12, 2023
Merged

Support PNPM v6+ Lockfile #325

merged 8 commits into from
Apr 12, 2023

Conversation

dbtedman
Copy link
Contributor

@dbtedman dbtedman commented Apr 2, 2023

A proposed fix for #324 issue.

@another-rex another-rex requested a review from G-Rath April 2, 2023 23:58
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution!! some comments/questions

pkg/lockfile/parse-pnpm-lock.go Outdated Show resolved Hide resolved
@dbtedman
Copy link
Contributor Author

dbtedman commented Apr 6, 2023

@oliverchang @G-Rath anything else you need from my end to be able to review this PR?

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @dbtedman!

Sorry for the slow reviews -- a lot of us here in APAC were out due to public holidays.

pkg/lockfile/parse-pnpm-lock.go Show resolved Hide resolved
pkg/lockfile/parse-pnpm-lock.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@oliverchang oliverchang merged commit 9f6b7e0 into google:main Apr 12, 2023
@dbtedman dbtedman deleted the support-pnpm-lockfile-v6 branch April 15, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants