Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check accepted fd instead of listen fd? #70

Open
tanjianfeng opened this issue Dec 15, 2022 · 1 comment · May be fixed by #71
Open

Check accepted fd instead of listen fd? #70

tanjianfeng opened this issue Dec 15, 2022 · 1 comment · May be fixed by #71

Comments

@tanjianfeng
Copy link

Is this a typo or deliberate? This line checked the listen fd (3), instead of accepted fd (4)?

https://github.com/google/packetdrill/blob/master/gtests/net/tcp/inq/server.pkt#L50

I guess the original purpose is to check this?

+0 read(4, ..., 2000) = 0
@nealcardwell
Copy link
Collaborator

Thanks for the report! We'll try to fix this. Or please feel free to post a patch. Thanks!

tanjianfeng added a commit to tanjianfeng/packetdrill that referenced this issue Dec 18, 2022
@tanjianfeng
packetdrill: check accepted fd instead of listen fd
b52e928 
It makes more sense to check the acceptd fd instead of listen fd in this
test case.

Fixes google#70.

Signed-off-by: Jianfeng Tan <henry.tjf@antgroup.com>
@tanjianfeng tanjianfeng linked a pull request Dec 18, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

packetdrill: check accepted fd instead of listen fd tanjianfeng/packetdrill
2 participants
@tanjianfeng @nealcardwell