Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

async-coap-uri: Stop using UriRawComponents::from_str as a crutch for validating Uri strings #10

Open
darconeous opened this issue Aug 26, 2019 · 0 comments
Open

async-coap-uri: Stop using UriRawComponents::from_str as a crutch for validating Uri strings #10

darconeous opened this issue Aug 26, 2019 · 0 comments
Labels
cleanup P2 Priority 2 performance Performance or optimization related task

Comments

@darconeous
Copy link
Contributor

We are currently using UriRawComponents::from_str as a crutch for validating Uri strings in the following places:

  • Uri::from_str
  • Uri::is_str_valid
  • UriRef::is_str_valid

This should be replaced with a more optimized check that doesn't break down the string into the components.
@darconeous darconeous added cleanup P2 Priority 2 task performance Performance or optimization related labels Aug 26, 2019
@darconeous darconeous changed the title Stop using UriRawComponents::from_str as a crutch for validating Uri strings async-coap-uri: Stop using UriRawComponents::from_str as a crutch for validating Uri strings Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cleanup P2 Priority 2 performance Performance or optimization related task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darconeous