Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined sanitizer issue #283

Closed
MBkkt opened this issue Nov 22, 2022 · 3 comments
Closed

Undefined sanitizer issue #283

MBkkt opened this issue Nov 22, 2022 · 3 comments

Comments

@MBkkt
Copy link
Contributor

MBkkt commented Nov 22, 2022

-fsanitize=nullability-arg: Passing null as a function parameter which is annotated with _Nonnull.

https://github.com/google/s2geometry/blob/master/src/s2/util/gtl/compact_array.h#L416

You can add if (old_capacity != 0)

Also if it something like vector with SSO, maybe better to use absl::InlinedVector?

@MBkkt
Copy link
Contributor Author

MBkkt commented Nov 22, 2022

#284

@jmr jmr closed this as completed in e15d00b Nov 28, 2022
@jmr
Copy link
Member

jmr commented Nov 28, 2022

Also if it something like vector with SSO, maybe better to use absl::InlinedVector?

CompactArray also has space optimizations, hence the "Compact".

@MBkkt
Copy link
Contributor Author

MBkkt commented Nov 28, 2022

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants