Add Append op for index files, manifests, and column stats. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coufon
force-pushed
the
coufon-dev2
branch
2 times, most recently
from
149963c
to
af82ef8
Compare
huan233usc
approved these changes
Dec 22, 2023
| stats_fields: List[Tuple[int, pa.DataType]] = [] | ||
|
|
||
| for f in schema: | ||
| if f.name not in primary_keys_: |
There was a problem hiding this comment.
Is the plan only extract column stats for pk?
There was a problem hiding this comment.
At least for beginning, unlike log style OLAP data, most well refined ML dataset has a primary key, and there is a need of deduplication. So call it as primary key. In future we can introduce clustering_key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.