Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate the impact of using the plugin #15

Open
maudnals opened this issue Apr 27, 2021 · 2 comments
Open

Estimate the impact of using the plugin #15

maudnals opened this issue Apr 27, 2021 · 2 comments
Assignees

Comments

@maudnals
Copy link
Collaborator

Compare the Lighthouse audit for a realistic app with vs. without this plugin.
See if there are any unexpected consequences of using the plugin.

@maudnals maudnals self-assigned this Apr 27, 2021
@maudnals
Copy link
Collaborator Author

maudnals commented Apr 27, 2021

Done. Audited the forked application react-real-world-example-app.

Full results:

Results summary:

  • Without the strict CSP plugin, perf audit = 22
  • With the strict CSP plugin, perf audit = 54 (🟢 better). Because all scripts became async, since we added them dynamically.
  • (all other audits are the same)

Conclusion:

@maudnals
Copy link
Collaborator Author

maudnals commented Apr 28, 2021

One way this could be an issue:
sourced script
then inline that uses some stuff from the sourced script

So, with our plugin:
the inline script will be left
but the sourced script will be loaded async
so inline will load before the sourced one <-- this may be an issue.

For SPAs, where everything's on the bundle.
GA and others are not dependent on order of each other

can be fixed with manual rewriting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant