Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

Commit

Permalink
Revert "Add automatic module name to Tink's Maven jar."
Browse files Browse the repository at this point in the history
This reverts commit 7bb05e7.

This change will be saved for inclusion in 1.7.0.
  • Loading branch information
chuckx committed Jul 12, 2021
1 parent 7e59bb5 commit 983c21e
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 29 deletions.
3 changes: 0 additions & 3 deletions apps/paymentmethodtoken/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ licenses(["notice"])
gen_maven_jar_rules(
name = "maven",
doctitle = "Tink Cryptography API for Google Payment Method Token",
manifest_lines = [
"Automatic-Module-Name: com.google.crypto.tink.apps.paymentmethodtoken",
],
root_packages = ["com.google.crypto.tink.apps.paymentmethodtoken"],
deps = [
"//paymentmethodtoken/src/main/java/com/google/crypto/tink/apps/paymentmethodtoken:google_payments_public_keys_manager",
Expand Down
3 changes: 0 additions & 3 deletions apps/rewardedads/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ licenses(["notice"])
gen_maven_jar_rules(
name = "maven",
doctitle = "Tink Cryptography API for Google Mobile Rewarded Video Ads SSV",
manifest_lines = [
"Automatic-Module-Name: com.google.crypto.tink.apps.rewardedads",
],
root_packages = ["com.google.crypto.tink.apps.rewardedads"],
deps = ["//rewardedads/src/main/java/com/google/crypto/tink/apps/rewardedads:rewarded_ads_verifier"],
)
3 changes: 0 additions & 3 deletions apps/webpush/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ licenses(["notice"])
gen_maven_jar_rules(
name = "maven",
doctitle = "Tink Cryptography API for Message Encryption for Web Push (RFC 8291)",
manifest_lines = [
"Automatic-Module-Name: com.google.crypto.tink.apps.webpush",
],
root_packages = ["com.google.crypto.tink.apps.webpush"],
deps = [
"//webpush/src/main/java/com/google/crypto/tink/apps/webpush:web_push_constants",
Expand Down
9 changes: 0 additions & 9 deletions java_src/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ exports_files(["BUILD"])
gen_maven_jar_rules(
name = "tink",
doctitle = "Tink Cryptography API",
manifest_lines = [
"Automatic-Module-Name: com.google.crypto.tink",
],
root_packages = [
"com.google.crypto.tink",
],
Expand Down Expand Up @@ -351,9 +348,6 @@ gen_maven_jar_rules(
gen_maven_jar_rules(
name = "tink-awskms",
doctitle = "Tink Cryptography API with AWS KMS",
manifest_lines = [
"Automatic-Module-Name: com.google.crypto.tink.integration.awskms",
],
root_packages = [
"com.google.crypto.tink",
],
Expand All @@ -366,9 +360,6 @@ gen_maven_jar_rules(
gen_maven_jar_rules(
name = "tink-gcpkms",
doctitle = "Tink Cryptography API with Google Cloud KMS",
manifest_lines = [
"Automatic-Module-Name: com.google.crypto.tink.integration.gcpkms",
],
root_packages = [
"com.google.crypto.tink",
],
Expand Down
7 changes: 1 addition & 6 deletions java_src/tools/gen_maven_jar_rules.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ def gen_maven_jar_rules(
doctitle = "",
android_api_level = 23,
bottom_text = "",
external_javadoc_links = _EXTERNAL_JAVADOC_LINKS,
manifest_lines = []):
external_javadoc_links = _EXTERNAL_JAVADOC_LINKS):
"""
Generates rules that generate Maven jars for a given package.
Expand All @@ -61,8 +60,6 @@ def gen_maven_jar_rules(
android_api_level: See javadoc_library
bottom_text: See javadoc_library
external_javadoc_links: See javadoc_library
manifest_lines: lines to put in the output manifest file (manifest
files in the input jars are ignored)
"""

if shaded_packages:
Expand All @@ -72,7 +69,6 @@ def gen_maven_jar_rules(
deps = deps,
resources = resources,
root_packages = root_packages + shaded_packages,
manifest_lines = manifest_lines,
)
jar_jar(
name = name,
Expand All @@ -85,7 +81,6 @@ def gen_maven_jar_rules(
deps = deps,
resources = resources,
root_packages = root_packages,
manifest_lines = manifest_lines,
)

source_jar_name = name + "-src"
Expand Down
5 changes: 0 additions & 5 deletions java_src/tools/java_single_jar.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ def _java_single_jar(ctx):
if ctx.attr.exclude_build_data:
args.add("--exclude_build_data")

args.add_all("--deploy_manifest_lines", ctx.attr.manifest_lines, format_each = "\"%s\"")

ctx.actions.run(
inputs = inputs.to_list() + resource_files,
outputs = [ctx.outputs.jar],
Expand All @@ -97,7 +95,6 @@ java_single_jar = rule(
"compress": attr.string(default = "preserve"),
"root_packages": attr.string_list(),
"exclude_build_data": attr.bool(default = True),
"manifest_lines": attr.string_list(),
},
outputs = {
"jar": "%{name}.jar",
Expand All @@ -123,8 +120,6 @@ Args:
root_packages: Java packages to include in generated jar.
exclude_build_data: Whether to omit the build-data.properties file generated
by default.
manifest_lines: lines to put in the output manifest file (manifest
files in the input jars are ignored)
Outputs:
{name}.jar: A single jar containing all of the input.
Expand Down

0 comments on commit 983c21e

Please sign in to comment.