Swap magic bytes for something more descriptive

This also has the benefit of not causing problems on old versions of MySQL, which broke with the emoji version.
google · Dec 5, 2023 · 02e48ff · 02e48ff
1 parent 6af1cb4
commit 02e48ff
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/cmd/createtree/main.go b/cmd/createtree/main.go
@@ -104,7 +104,7 @@ func newRequest() (*trillian.CreateTreeRequest, error) {
 		TreeState:       trillian.TreeState(ts),
 		TreeType:        trillian.TreeType(tt),
 		DisplayName:     *displayName,
-		Description:     "🙃norevs🙃 " + *description,
+		Description:     "[NO_SUBTREE_REVISIONS] " + *description,
 		MaxRootDuration: durationpb.New(*maxRootDuration),
 	}}
 	klog.Infof("Creating tree %+v", ctr.Tree)

diff --git a/storage/mysql/tree_storage.go b/storage/mysql/tree_storage.go
@@ -159,7 +159,7 @@ func (m *mySQLTreeStorage) beginTreeTx(ctx context.Context, tree *trillian.Tree,
 	}
 	// If the tree description starts with magic constant then we will only write a single
 	// revision for each subtree tile, which simplifies the reading query.
-	subtreeRevs := !strings.HasPrefix(tree.Description, "🙃norevs🙃")
+	subtreeRevs := !strings.HasPrefix(tree.Description, "[NO_SUBTREE_REVISIONS]")
 	return treeTX{
 		tx:            t,
 		mu:            &sync.Mutex{},

diff --git a/storage/testonly/admin_storage_tester.go b/storage/testonly/admin_storage_tester.go
@@ -47,7 +47,7 @@ var (
 		TreeState:       trillian.TreeState_ACTIVE,
 		TreeType:        trillian.TreeType_LOG,
 		DisplayName:     "Llamas Log",
-		Description:     "🙃norevs🙃 Registry of publicly-owned llamas",
+		Description:     "[NO_SUBTREE_REVISIONS] Registry of publicly-owned llamas",
 		MaxRootDuration: durationpb.New(0 * time.Millisecond),
 	}