Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.11 tools use $GOFLAGS automatically #1276

Closed
RJPercival opened this issue Sep 7, 2018 · 2 comments · Fixed by #1469
Closed

Go 1.11 tools use $GOFLAGS automatically #1276

RJPercival opened this issue Sep 7, 2018 · 2 comments · Fixed by #1469
Assignees
Labels

Comments

@RJPercival
Copy link
Contributor

RJPercival commented Sep 7, 2018

Our Travis config uses an environment variable called $GOFLAGS to store the flags to pass to some Go commands it uses, e.g.

- go get ${GOFLAGS} -d -t ./...

Go 1.11 will read the $GOFLAGS variable itself so we won't need to use it as part of any commands. This will, however, possibly result in other go commands we use getting these flags where previously they didn't.

@daviddrysdale
Copy link
Contributor

(Nothing to do until we move our Travis builds to use Go 1.11)

@daviddrysdale
Copy link
Contributor

Also: gometalinter fixed upstream for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants