Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove export GO111MODULE=auto in README.md #2773

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Remove export GO111MODULE=auto in README.md #2773

merged 1 commit into from
Jul 7, 2022

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Jul 6, 2022

As the minimum Go version in Trillian becomes 1.17, the default value of GO111MODULE is on which is equivalent to auto. The export GO111MODULE=auto is unnecessary.

Checklist

@roger2hk roger2hk requested a review from a team as a code owner July 6, 2022 14:58
@roger2hk roger2hk requested a review from pphaneuf July 6, 2022 14:58
@roger2hk roger2hk merged commit bc144be into google:master Jul 7, 2022
@roger2hk roger2hk deleted the remove-go111module-readme branch July 7, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

@pphaneuf pphaneuf Awaiting requested review from pphaneuf pphaneuf is a code owner automatically assigned from google/trillian-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roger2hk @mhutchinson