-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/transparency-dev/merkle from 0.0.1 to 0.0.2 #2987
Conversation
github.com/transparency-dev/merkle was updated to 0.0.2 by Dependabot in #2990, so this is no longer needed. |
Interestingly enough, it did not update CHANGELOG.md, facepalm. |
I usually see the Dependabot updates in the generated release notes. |
Yeah but I think the goal of CHANGELOG.md is to keep track of noteworthy updates, which I believe this one was. I would not expect all the dependencies updates to be in CHANGELOG.md for instance. Or maybe we want? They were added for v1.5.1 for instance. Clarity in the PR checklist and release documentation would help here, to clarify whether:
|
According to our internal team doc, the CHANGELOG.md is expected to include any non-trivial (or trival but noteworthy) changes. The merkle dependency is a trival but noteworthy change, so it's good to include it. |
Good, I've put them there with the release notes. |
upgrade transparency-dev/merkle from v0.0.1 to v0.0.2
Checklist