Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/transparency-dev/merkle from 0.0.1 to 0.0.2 #2987

Closed
wants to merge 3 commits into from

Conversation

phbnf
Copy link
Contributor

@phbnf phbnf commented May 5, 2023

upgrade transparency-dev/merkle from v0.0.1 to v0.0.2

Checklist

@phbnf phbnf requested a review from a team as a code owner May 5, 2023 10:59
@phbnf phbnf requested review from getagit and roger2hk and removed request for getagit May 5, 2023 10:59
@roger2hk roger2hk changed the title upgrade transparency-dev/merkle from v0.0.1 to v0.0.2 @phbnf Bump transparency-dev/merkle from v0.0.1 to v0.0.2 May 5, 2023
@roger2hk roger2hk changed the title Bump transparency-dev/merkle from v0.0.1 to v0.0.2 Bump transparency-dev/merkle from 0.0.1 to 0.0.2 May 5, 2023
@roger2hk roger2hk changed the title Bump transparency-dev/merkle from 0.0.1 to 0.0.2 Bump github.com/transparency-dev/merkle from 0.0.1 to 0.0.2 May 5, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@roger2hk
Copy link
Contributor

roger2hk commented May 9, 2023

github.com/transparency-dev/merkle was updated to 0.0.2 by Dependabot in #2990, so this is no longer needed.

@roger2hk roger2hk closed this May 9, 2023
@phbnf
Copy link
Contributor Author

phbnf commented May 9, 2023

Interestingly enough, it did not update CHANGELOG.md, facepalm.

@roger2hk
Copy link
Contributor

roger2hk commented May 9, 2023

I usually see the Dependabot updates in the generated release notes.

@phbnf
Copy link
Contributor Author

phbnf commented May 9, 2023

Yeah but I think the goal of CHANGELOG.md is to keep track of noteworthy updates, which I believe this one was. I would not expect all the dependencies updates to be in CHANGELOG.md for instance. Or maybe we want? They were added for v1.5.1 for instance. Clarity in the PR checklist and release documentation would help here, to clarify whether:

  • one should update the CHANGELOG.md for dependecy updates
  • whether we want CHANGELOG.md to contain all the change, or only noteworthy ones

@roger2hk
Copy link
Contributor

roger2hk commented May 9, 2023

According to our internal team doc, the CHANGELOG.md is expected to include any non-trivial (or trival but noteworthy) changes. The merkle dependency is a trival but noteworthy change, so it's good to include it.

@phbnf
Copy link
Contributor Author

phbnf commented May 10, 2023

Good, I've put them there with the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants