Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move golangci-lint from Cloud Build to GitHub Action #3188

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Nov 6, 2023

The Cloud Build duration will be slightly shorten by moving the golangci-lint to GitHub Action workflow.

Checklist

@roger2hk roger2hk requested a review from a team as a code owner November 6, 2023 20:32
@roger2hk
Copy link
Contributor Author

roger2hk commented Nov 7, 2023

I have no clue why the trillian-pr-tests keeps failing.

@AlCutter
Copy link
Member

AlCutter commented Nov 7, 2023

Seems to be failing to look up the ip address of the DB host, although I'm not sure why this should have just started happening...

W1107 00:24:37.895519    2548 tree_storage.go:81] Failed to set strict mode on mysql db: dial tcp: lookup 1c8e0e9187d0_db_1 on 127.0.0.11:53: no such host
F1107 00:24:37.895561    2548 main.go:118] Failed to get storage provider: dial tcp: lookup 1c8e0e9187d0_db_1 on 127.0.0.11:53: no such host
exit status 1

@mhutchinson
Copy link
Contributor

Any insights into what the problem with the DB connection is? Seems suspicious that it's happened so soon after the upgrade to MySQL 8, but weird that it's happening on this PR now. Looks like other PRs have gone in fine since. I've made the target re-run but I assume someone has already tried that?

@mhutchinson
Copy link
Contributor

Looks like it was just a flake.

@roger2hk
Copy link
Contributor Author

roger2hk commented Nov 8, 2023

Looks like it was just a flake.

Thanks Martin. I guess I had some bad luck on that day.

@roger2hk roger2hk merged commit 9e85a5e into google:master Nov 8, 2023
10 checks passed
@roger2hk roger2hk deleted the golangci-lint branch September 24, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants