Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Expect throw ComparisonFailure when possible #543

Open
cpovirk opened this issue Apr 10, 2019 · 2 comments
Open

Make Expect throw ComparisonFailure when possible #543

cpovirk opened this issue Apr 10, 2019 · 2 comments
Labels
P3 not scheduled type=enhancement Make an existing feature better

Comments

@cpovirk
Copy link
Member

cpovirk commented Apr 10, 2019

Currently, it always throws AssertionError. But if there's only one failure and it's a ComparisonFailure, we should throw ComparisonFailure. Arguably we could throw ComparisonFailure even in the case of multiple failures, at least if only one input is a ComparisonFailure, though that's potentially confusing.

@cpovirk
Copy link
Member Author

cpovirk commented Apr 10, 2019

Arguably we could throw ComparisonFailure even in the case of multiple failures, at least if only one input is a ComparisonFailure, though that's potentially confusing.

I forgot that there's MultipleFailuresError if we move to opentest4j (#333). That might help.

@raghsriniv raghsriniv added the P3 not scheduled label Jun 24, 2019
@kluever kluever added the type=enhancement Make an existing feature better label Aug 12, 2019
@cpovirk
Copy link
Member Author

cpovirk commented Apr 20, 2020

There's also a MultipleFailuresException in JUnit 4. But it looks like that might be less supported by IDEs than MultipleFailuresError (which itself might not be heavily supported).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 not scheduled type=enhancement Make an existing feature better
Projects
None yet
Development

No branches or pull requests

3 participants