-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support string templates #303
Comments
@cushon are you (going to be) actively working on this? Or would you possibly welcome a contribution with a fix? |
copybara-service bot
pushed a commit
that referenced
this issue
Jan 29, 2024
#303 PiperOrigin-RevId: 602189523
Merged
copybara-service bot
pushed a commit
that referenced
this issue
Jan 29, 2024
#303 PiperOrigin-RevId: 602189523
copybara-service bot
pushed a commit
that referenced
this issue
Jan 29, 2024
#303 PiperOrigin-RevId: 602189523
copybara-service bot
pushed a commit
that referenced
this issue
Jan 29, 2024
#303 PiperOrigin-RevId: 602458900
@cushon close this? (Next step is bazelbuild/bazel#21128.) |
copybara-service bot
pushed a commit
that referenced
this issue
May 16, 2024
Rollback of 2b0a592. I kept some changes to `IntegrationTestSupport` and `LowerIntegrationTest` related to testing preview features, which may be needed again in the future. See https://bugs.openjdk.org/browse/JDK-8329949 #303 PiperOrigin-RevId: 633967314
copybara-service bot
pushed a commit
that referenced
this issue
May 16, 2024
Rollback of 2b0a592. I kept some changes to `IntegrationTestSupport` and `LowerIntegrationTest` related to testing preview features, which may be needed again in the future. See https://bugs.openjdk.org/browse/JDK-8329949 #303 PiperOrigin-RevId: 634284408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See https://openjdk.org/jeps/430
String templates aren't compile-time constants, so they don't affect ABI. The fix should be to handle them during lexing and parsing so we can cleanly skip over the value of the template.
The text was updated successfully, but these errors were encountered: