Allow path to ct.sym to be specified via a system property
#296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When turbine is compiled into a native image, no JAVA_HOME will be available at runtime and the `java.home` system property won't be set. To still provide support for `--release` in that situation, the new `turbine.ctSymPath` system property can be set to give turbine the required access to `ct.sym`.
|
CC @cushon |
cushon
approved these changes
Nov 21, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
When turbine is compiled into a native image, no JAVA_HOME will be available at runtime and the `java.home` system property won't be set. To still provide support for `--release` in that situation, the new `turbine.ctSymPath` system property can be set to give turbine the required access to `ct.sym`. Work towards bazelbuild/stardoc#195 (comment) Fixes #296 FUTURE_COPYBARA_INTEGRATE_REVIEW=#296 from fmeum:ctsym b74452b PiperOrigin-RevId: 584409250
|
@cushon Thanks for the quick merge. I can update the version in Bazel when the Maven release is out. |
|
Thanks @fmeum! I just pushed the maven release, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When turbine is compiled into a native image, no JAVA_HOME will be available at runtime and the
java.homesystem property won't be set. To still provide support for--releasein that situation, the newturbine.ctSymPathsystem property can be set to give turbine the required access toct.sym.Work towards bazelbuild/stardoc#195 (comment)