Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: GoogleCloudDisk processing requests should fail sooner for local installs #1471

Open
aarontp opened this issue Apr 13, 2024 · 1 comment
Labels
enhancement Needs triage New issues that need triage

Comments

@aarontp
Copy link
Member

aarontp commented Apr 13, 2024

What is the feature you are proposing?

Currently a "local" installation of Turbinia will accept a GoogleCloudDisk processing request even if it won't be able to process it and all Tasks will fail with an error similar to Task Result was auto-closed from task executor on <worker name> likely due to previous failures. Previous status: [FileArtifactExtractionTask Task failed with exception: [name 'google_cloud' is not defined]]. It would be nice if either the client rejected this immediately or the API server rejected it when the request was submitted. Previously turbiniactl was able to load the config and determine if the server was a cloud instance or not, but the turbinia-client doesn't necessarily have access to this, so it might need to be done at the API server.

What would this feature improve or what problem would it solve?

This will be much easier for users to understand because a) they see it earlier when the request is made and b) the error can be much clearer as to what the real problem is.

What alternatives have you considered?

n/a

@aarontp aarontp added enhancement Needs triage New issues that need triage labels Apr 13, 2024
@aarontp
Copy link
Member Author

aarontp commented Apr 13, 2024

FYI @jleaniz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Needs triage New issues that need triage
Projects
None yet
Development

No branches or pull requests

1 participant