You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Describe the bug
Creating a proposal with an empty commit link currently leads to the application error: "Please specify a valid commit link".
To Reproduce
Steps to reproduce the behavior:
Go to any vulnerability entry (with an existing commit link).
Propose changes and leave commit link empty or remove it.
Submit changes.
Expected behavior
Commit links are supposed to be optional.
Additional context data/models/vulnerability.py has a commit_link.setter. Using just a return for empty strings leads to an error in the diff algorithm in data/models/base.py where it would not recognize that the commit link has been changed and reject the proposal.
The text was updated successfully, but these errors were encountered:
There is also redundant code like if form_submitted and commit["commit_link"]: in the router logic for vulnerabilities and profiles that attempts to validate a commit link once it has been passed. Once this is fixed we should be able to remove such code.
Clearing an existing commit link also requires to remove the respective linked commit entry in the database. So this requires at least the following, separate steps:
Allowing empty commit links on new/vanilla entries
Allowing to clear commit links on existing entries
Removal of commit entries if a commit link was cleared
Improving the diff code
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
Creating a proposal with an empty commit link currently leads to the application error: "Please specify a valid commit link".
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Commit links are supposed to be optional.
Additional context
data/models/vulnerability.py
has acommit_link.setter
. Using just a return for empty strings leads to an error in the diff algorithm indata/models/base.py
where it would not recognize that the commit link has been changed and reject the proposal.The text was updated successfully, but these errors were encountered: