Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "release new crate version" workflow #1172

Merged
merged 1 commit into from
May 3, 2024

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented May 3, 2024

This can be triggered manually via the GitHub web UI, and will generate a PR which updates the crate versions in both Cargo.toml files.

@joshlf joshlf force-pushed the update-crate-versions-workflow branch 2 times, most recently from e789c38 to fc7d2d0 Compare May 3, 2024 10:49
This can be triggered manually via the GitHub web UI, and will generate
a PR which updates the crate versions in both `Cargo.toml` files.
@joshlf joshlf force-pushed the update-crate-versions-workflow branch from 4cb3c4f to b10d3b1 Compare May 3, 2024 10:56
@joshlf joshlf requested a review from jswrenn May 3, 2024 10:57
@joshlf joshlf enabled auto-merge May 3, 2024 10:57
@joshlf
Copy link
Member Author

joshlf commented May 3, 2024

I tested this manually by temporarily adding a pull_request trigger to this workflow, which generated #1173.

Note that the GitHub Actions meta-variable ${{ github.event.inputs.version }} is not set when triggered by pull_request, so the fact that the version string is empty in that PR is expected given the testing methodology.

This was referenced May 3, 2024
Copy link
Collaborator

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd also be nice to parameterize this by branch so we could use the same process for releases to older version trains, but this looks like a great start to me!

@joshlf joshlf added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit c7b3005 May 3, 2024
210 checks passed
@joshlf joshlf deleted the update-crate-versions-workflow branch May 3, 2024 12:49
@joshlf
Copy link
Member Author

joshlf commented May 3, 2024

Now that this is merged, here's a better example of a PR - this one generated via the manual trigger UI: #1178

@joshlf joshlf mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants