Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong types in ReportQuery #292

Closed
bernhard-efler opened this issue May 16, 2017 · 2 comments
Closed

Wrong types in ReportQuery #292

bernhard-efler opened this issue May 16, 2017 · 2 comments
Assignees
@fiboknacky

Comments

@bernhard-efler
Copy link

bernhard-efler commented May 16, 2017 •
edited
Loading

In the ReportQuery the types for dimensions, columns and dimensionAttributes are invalid.
They are array, not string. To to be precise: string[]

That does not work:
$reportQuery->setDimensions(\implode(' ', [Dimension::LINE_ITEM_ID, Dimension::LINE_ITEM_NAME]));

This does:
$reportQuery->setDimensions([Dimension::LINE_ITEM_ID, Dimension::LINE_ITEM_NAME]);
@fiboknacky
Copy link
Member

Hi @Montolio

Thanks for reporting. Will have a look.

Knack

@fiboknacky fiboknacky self-assigned this May 16, 2017
@fiboknacky fiboknacky mentioned this issue Jun 1, 2017
Closed
@fiboknacky
Copy link
Member

This is fixed in v28.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fiboknacky fiboknacky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fiboknacky @bernhard-efler