test: Added Travis CI credentials for browserstack. (#511)

* test: Added Travis CI credentials for browserstack.

* test: check for Travis pull request

* docs: updated DEVELOPING.md

* docs: added note about npm test

.travis.yml

@@ -8,7 +8,10 @@ env:
 addons:
   chrome: stable
   firefox: latest
+  browserstack:
+    username: "adsdevrel1"
+    access_key:
+      secure: "KJVna2yQYeX9dwNLzNSTjMxjCxLa8d5wuxlq414TP+gKPlMjcLohi05C0nno73qlsYkPw+w7leG9tSP3gPFfylCKKGUqX6oXPEjo59SysTz+MQMnwglvdiAB5kVW5/AGdhWfnOGM5bsDHYVoDKe5M+xANOxIsQA3tMgUdV+gVVs="
 scripts:
   - npm run lint
   - npm test
-

DEVELOPING.md

@@ -28,3 +28,9 @@ To create a new release, run the following:
 npm version [major|minor|patch]
 npm publish
 ```
+Be sure to run the tests with Browserstack. To do so you'll need to set the
+`BROWSERSTACK_USER` and `BROWSERSTACK_ACCESS_KEY` environment variables. Then run:
+
+```
+npm test
+```

test/webdriver/content/capabilities.js

@@ -21,7 +21,7 @@ var browserstackCapabilities = {
   'build' : '1.0.5',
   'project' : 'videojs_ima',
   'browserstack.local' : 'true',
-  'browserstack.localIdentifier' : 'Test001',
+  'browserstack.localIdentifier' : process.env.BROWSERSTACK_LOCAL_IDENTIFIER,
   'browserstack.user' : process.env.BROWSERSTACK_USER,
   'browserstack.key' : process.env.BROWSERSTACK_KEY
 }
@@ -67,15 +67,22 @@ var browsers = [
   },
 ];
 
+// For running locally.
+if (process.env.BROWSERSTACK_LOCAL_IDENTIFIER === undefined) {
+  browserstackCapabilities['browserstack.localIdentifier'] = "Test001";
+}
+
 for (let browser of browsers) {
   if (browser.server == 'http://hub-cloud.browserstack.com/wd/hub') {
     browser.capabilities =
         Object.assign(browser.capabilities, browserstackCapabilities);
   }
 }
 
-if (process.env.BROWSERSTACK_USER === undefined ||
-    process.env.BROWSERSTACK_KEY === undefined) {
+// Remove if we don't have browserstack credentials.
+if (process.env.TRAVIS_PULL_REQUEST ||
+    process.env.BROWSERSTACK_USER === undefined ||
+    process.env.BROWSERSTACK_ACCESS_KEY === undefined) {
   browsers = browsers.filter(browser =>
     browser.server != 'http://hub-cloud.browserstack.com/wd/hub');
 }