-
Notifications
You must be signed in to change notification settings - Fork 284
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: Update autoplay sample and how we report adsWillAutoplay an… (
#562) * refactor: Update autoplay sample and how we report adsWillAutoplay and adsWillPlayMuted. Also deprecates the options ad(s)WillPlayMuted and ad(s)WillAutoPlay. Fixes #341. * Update README to indicate that setAdWillPlayMuted is deprecated. * Use getPlayerOptions() instead of vjsPlayer.options_ in controller getAdsWillAutoplay. * Add can-autoplay to release script for gh-pages. * Move can-autoplay from devDependencies to dependencies. I feel like if it's required to run the samples then it should probably be in dependencies. * Fix lint errors. * Move accidental extra file. * Fix example - check unmuted support first, then muted.
- Loading branch information
Showing
10 changed files
with
676 additions
and
403 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Where was this announced? I'm not seeing it as deprecated on the IMA documentation website. https://developers.google.com/interactive-media-ads/docs/sdks/html5/v3/apis#ima.AdsRequest.setAdWillPlayMuted