refactor: Deprecated id setting, instead get the id from Vjs player. (#…

…625)

src/ad-ui.js

@@ -105,8 +105,7 @@ const AdUi = function(controller) {
   /**
    * Used to prefix videojs ima controls.
    */
-  this.controlPrefix = this.controller.getSettings().id ?
-      this.controller.getSettings().id + '_' : '';
+  this.controlPrefix = this.controller.getPlayerId() + '_';
 
   /**
    * Boolean flag to show or hide the ad countdown timer.

src/controller.js

@@ -96,11 +96,6 @@ Controller.IMA_DEFAULTS = {
 Controller.prototype.initWithSettings = function(options) {
   this.settings = this.extend({}, Controller.IMA_DEFAULTS, options || {});
 
-  if (!this.settings.id) {
-    window.console.error('Error: must provide id of video.js div');
-    return;
-  }
-
   this.warnAboutDeprecatedSettings();
 
   // Default showing countdown timer to true.
@@ -662,6 +657,13 @@ Controller.prototype.getAdsManager = function() {
   return this.sdkImpl.getAdsManager();
 };
 
+/**
+ * Returns the instance of the player id.
+ * @return {string} The player id.
+ */
+Controller.prototype.getPlayerId = function() {
+  return this.playerWrapper.getPlayerId();
+};
 
 /**
  * Changes the ad tag. You will need to call requestAds after this method

src/player-wrapper.js

@@ -266,7 +266,7 @@ PlayerWrapper.prototype.onReadyForPreroll = function() {
 PlayerWrapper.prototype.onPlayerReady = function() {
   this.h5Player =
       document.getElementById(
-          this.controller.getSettings().id).getElementsByClassName(
+          this.getPlayerId()).getElementsByClassName(
               'vjs-tech')[0];
 
   // Detect inline options
@@ -407,6 +407,13 @@ PlayerWrapper.prototype.getPlayerOptions = function() {
   return this.vjsPlayer.options_;
 };
 
+/**
+ * Returns the instance of the player id.
+ * @return {string} The player id.
+ */
+PlayerWrapper.prototype.getPlayerId = function() {
+  return this.vjsPlayer.id();
+};
 
 /**
  * Toggle fullscreen state.