feat: Allow for an adsRequest object to be passed to the plugin. This… #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allows us to support additional adRequest properties. Fixes #653.
ypavlotsky
reviewed
Jun 13, 2018
README.md
Outdated
| | adsResponse | string | REQUIRED IF adTagUrl IS NOT PROVIDED The VAST, VMAP, or ad rules response to use,in lieu of fetching one an ad tag. | | ||
| | adTagUrl | string | A URL which returns a VAST, VMAP or ad rules,response. This will override adsResponse. | | ||
| | adsResponse | string | The VAST, VMAP, or ad rules response to use,in lieu of fetching one an ad tag. This is overridden if adTagUrl is set. | | ||
| | adsRequest | object | JSON object with ads request properties defined in the IMA SDK Docs(2). Propertied set here that can also be provided elsewhere (e.g. adTagUrl) will override those other settings. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… allows us to support additional adRequest properties. Fixes #653.