-
Notifications
You must be signed in to change notification settings - Fork 32
fix: enable complex resource ids in instantiate() #159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
============================================
+ Coverage 64.09% 64.43% +0.33%
- Complexity 171 174 +3
============================================
Files 14 14
Lines 713 717 +4
Branches 118 120 +2
============================================
+ Hits 457 462 +5
+ Misses 220 219 -1
Partials 36 36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I just tested this out with a local build, and it seems to have fixed the problem. Thank you for the quick fix here! Any idea when this might make it into the next release. As mentioned in #154, we have another large body of work which depends on this feature, with a hard deadline in mid-July. |
Truth.assertThat(match.get("foo")).isEqualTo("foo1"); | ||
Truth.assertThat(match.get("bar")).isEqualTo("bar2"); | ||
variables = template.vars(); | ||
System.out.println("DEL: vars: " + variables); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be here
.containsExactly("foo", "bar", "zone_a", "zone_b", "zone_c", "cell1", "cell2"); | ||
|
||
pattern = "projects/{foo}_{bar}/zones/*"; | ||
template = PathTemplate.create(pattern); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local variables probably shouldn't be reused
Fixes #154.