Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(AIP-132): fix incorrect field for AIP-217 #1423

Merged
merged 1 commit into from
Aug 28, 2024
Merged

docs(AIP-132): fix incorrect field for AIP-217 #1423

merged 1 commit into from
Aug 28, 2024

Conversation

Juneezee
Copy link
Contributor

The field name "unavailable" listed on https://linter.aip.dev/132/response-unknown-fields is incorrect. According to AIP-217, the field should be "unreachable".

According to AIP-217, the field should be "unreachable" instead of
"unavailable".

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@Juneezee Juneezee requested a review from a team as a code owner August 28, 2024 15:52
@noahdietz
Copy link
Collaborator

Great catch! Thank you!

@noahdietz noahdietz added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 28, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6a52a68 into googleapis:main Aug 28, 2024
6 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 28, 2024
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 23, 2024
🤖 I have created a release *beep* *boop*
---


## [1.67.3](https://github.com/googleapis/api-linter/compare/v1.67.2...v1.67.3) (2024-09-23)


### Bug Fixes

* **AIP-132:** refine List request response regex ([#1420](https://github.com/googleapis/api-linter/issues/1420)) ([5cc4d27](https://github.com/googleapis/api-linter/commit/5cc4d279c9cfc80545a9d2447b4fe13a8032b2aa))
* **AIP-136:** ignore revision methods ([#1432](https://github.com/googleapis/api-linter/issues/1432)) ([a6ba5f3](https://github.com/googleapis/api-linter/commit/a6ba5f32458cefc42b662019d97199d0a8e86551))
* **AIP-162:** handle LRO in response name rules ([#1431](https://github.com/googleapis/api-linter/issues/1431)) ([8bca1dd](https://github.com/googleapis/api-linter/commit/8bca1dd68ccf00c39a06da9862ac8c599029297e))
* **internal/utils:** refine Get, Create, Update, Delete request regex ([#1422](https://github.com/googleapis/api-linter/issues/1422)) ([487328c](https://github.com/googleapis/api-linter/commit/487328ca8708521562be2921d3c4f2aabaf8a5ae))
* **locations:** make source info access concurrent safe ([#1433](https://github.com/googleapis/api-linter/issues/1433)) ([223aa5b](https://github.com/googleapis/api-linter/commit/223aa5bb6cf4f24193ad6c6037e1b88160474f2e))


### Documentation

* **AIP-132:** fix incorrect field for AIP-217 ([#1423](https://github.com/googleapis/api-linter/issues/1423)) ([6a52a68](https://github.com/googleapis/api-linter/commit/6a52a6845bf8f240a4d9f9a305a26609a2699c17))
* **AIP-134:** change mandated to recommended ([#1426](https://github.com/googleapis/api-linter/issues/1426)) ([338b6a9](https://github.com/googleapis/api-linter/commit/338b6a95906b61ba5a83805bce92919dd53725dc))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants