Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade webrick dep #1441

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lamcodeofpwnosec
Copy link
Contributor

An issue was discovered in the WEBrick toolkit through 1.8.1 for Ruby. It allows HTTP request smuggling by providing both a Content-Length header and a Transfer-Encoding header, e.g., "GET /admin HTTP/1.1\r\n" inside of a "POST /user HTTP/1.1\r\n" request. NOTE: the supplier's position is "Webrick should not be used in production."

@lamcodeofpwnosec lamcodeofpwnosec requested a review from a team as a code owner October 28, 2024 15:55
Copy link

conventional-commit-lint-gcf bot commented Oct 28, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@noahdietz
Copy link
Collaborator

Here is the CVE GHSA-6f62-3596-g6w7

@noahdietz noahdietz changed the title Fix(deps): Inconsistent Interpretation of HTTP Requests Smuggling fix(deps): Inconsistent Interpretation of HTTP Requests Smuggling Oct 28, 2024
@noahdietz noahdietz enabled auto-merge (squash) October 28, 2024 16:00
@noahdietz noahdietz disabled auto-merge October 28, 2024 16:00
@noahdietz noahdietz added the automerge Summon MOG for automerging label Oct 28, 2024
@noahdietz noahdietz changed the title fix(deps): Inconsistent Interpretation of HTTP Requests Smuggling fix(deps): upgrade webrick dep Oct 28, 2024
@noahdietz
Copy link
Collaborator

Thank you @lamcodeofpwnosec

@gcf-merge-on-green gcf-merge-on-green bot merged commit 30b0a84 into googleapis:main Oct 28, 2024
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants