Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove @google-cloud/common retries for CreateProfile and UpdateProfile requests #555

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

nolanmar511
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2019
@nolanmar511 nolanmar511 changed the title fix: remove CreateProfile and UpdateProfile retries added by @google-cloud/common fix: remove @google-cloud/common retries for CreateProfile and UpdateProfile requests Oct 16, 2019
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #555 into master will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   75.73%   76.47%   +0.73%     
==========================================
  Files           7        7              
  Lines         272      272              
  Branches       56       56              
==========================================
+ Hits          206      208       +2     
+ Misses         50       49       -1     
+ Partials       16       15       -1
Impacted Files Coverage Δ
ts/src/profiler.ts 89.5% <ø> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437bd29...6b7cecc. Read the comment docs.

@nolanmar511 nolanmar511 merged commit 09ef74d into googleapis:master Oct 17, 2019
@nolanmar511 nolanmar511 deleted the remove-retries branch October 17, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants