Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several tests fail on Node 12 #1017

Closed
kjin opened this issue May 4, 2019 · 2 comments
Closed

Several tests fail on Node 12 #1017

kjin opened this issue May 4, 2019 · 2 comments
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kjin
Copy link
Contributor

kjin commented May 4, 2019 •
edited
Loading

On Node 12, it appears that the existence of a before async hook affects whether our generic-pool test passes (it passes if the hook is registered, but we don't register it). I'm currently unsure whether this is because of a flawed test or if tracing is actually broken for the module (or if it's a Node bug).

EDIT: Still investigating. Seems like the initial assertion about the before async hooks was irrelevant.
@kjin kjin added priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 4, 2019
@kjin kjin self-assigned this May 4, 2019
@kjin kjin changed the title generic-pool@3 tests fail on Node 12 Several tests fail on Node 12 May 6, 2019
@kjin
Copy link
Contributor Author

kjin commented May 6, 2019 •
edited
Loading

This appears to be a result of a Node 12 bug where having an async hook that has been disabled once, and then re-enabled, results in incorrect tracing, as re-enabling the hook doesn't re-enable the async ID tracking. I'll report the issue at the Node core repo and close this one.

@kjin kjin mentioned this issue May 6, 2019
Merged
@kjin
Copy link
Contributor Author

kjin commented May 6, 2019

nodejs/node#27585

@kjin kjin closed this as completed May 6, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjin