Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add config.disableUntracedModulesWarn #1070

Merged
merged 1 commit into from
Jul 18, 2019
Merged

feat: add config.disableUntracedModulesWarn #1070

merged 1 commit into from
Jul 18, 2019

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jul 17, 2019

Fixes #1066

@kjin kjin requested a review from a team July 17, 2019 19:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2019
@kjin kjin mentioned this pull request Jul 17, 2019
Closed
@kjin kjin force-pushed the disable-untraced-modules-warn branch from 00e86bf to f4f9167 Compare July 18, 2019 17:11
@codecov
Copy link

codecov bot commented Jul 18, 2019 •
edited
Loading

Codecov Report

Merging #1070 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
+ Coverage   94.92%   94.93%   +<.01%     
==========================================
  Files          96       96              
  Lines        6386     6397      +11     
  Branches      496      498       +2     
==========================================
+ Hits         6062     6073      +11     
  Misses        166      166              
  Partials      158      158
Impacted Files Coverage Δ
src/tracing.ts 90% <ø> (ø) ⬆️
src/config.ts 100% <ø> (ø) ⬆️
src/index.ts 89.65% <100%> (+0.36%) ⬆️
test/test-modules-loaded-before-agent.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf423c...f4f9167. Read the comment docs.

@kjin kjin merged commit f688e33 into googleapis:master Jul 18, 2019
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
@EitanGayor EitanGayor mentioned this pull request May 31, 2024
Open
@EitanGayor EitanGayor mentioned this pull request Jun 22, 2024
Open
This was referenced Jul 17, 2024
Open
Open
@EitanGayor EitanGayor mentioned this pull request Jul 27, 2024
Open
@EitanGayor EitanGayor mentioned this pull request Aug 22, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Open
@EitanGayor EitanGayor mentioned this pull request Sep 14, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
@dazdaz dazdaz mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soldair soldair soldair approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logModulesLoadedBeforeTrace should log a warning not an error, and should have a flag to disable the warning
3 participants
@kjin @soldair @googlebot