Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mongodb@3.3+ #1123

Closed
kjin opened this issue Sep 26, 2019 · 0 comments · Fixed by #1134
Closed

Support mongodb@3.3+ #1123

kjin opened this issue Sep 26, 2019 · 0 comments · Fixed by #1134
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kjin
Copy link
Contributor

kjin commented Sep 26, 2019

Per mongodb release notes, mongodb-core is now folded into mongodb: https://github.com/mongodb/node-mongodb-native/releases/tag/v3.3.0

In order to continue supporting mongoose (starting at 5.7), we will now need to support mongodb.
@kjin kjin added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 26, 2019
@kjin kjin self-assigned this Sep 26, 2019
@kjin kjin mentioned this issue Sep 26, 2019
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Oct 1, 2019
@kjin kjin mentioned this issue Oct 3, 2019
Merged
@kjin kjin closed this as completed in #1134 Oct 4, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: tracing not working in mongoose 3.3+ kjin/cloud-trace-nodejs
2 participants
@kjin @yoshi-automation