Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Hex value assertion was used on decimal string #1271

Merged
merged 2 commits into from
May 29, 2020
Merged

fix(tests): Hex value assertion was used on decimal string #1271

merged 2 commits into from
May 29, 2020

Conversation

kintel
Copy link
Contributor

@kintel kintel commented May 29, 2020

Fixes #1260

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2020
@kintel kintel requested a review from ZiweiZhao May 29, 2020 16:46
ZiweiZhao
ZiweiZhao approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@ZiweiZhao ZiweiZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZiweiZhao ZiweiZhao merged commit 5def451 into googleapis:master May 29, 2020
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiweiZhao ZiweiZhao ZiweiZhao approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mocha Tests: creates a TraceSpan structure with expected fields failed
3 participants
@kintel @ZiweiZhao @googlebot