Return the patched promise, not the original one #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
punya
force-pushed
the
fix-promise-patching
branch
4 times, most recently
from
d407877
to
87dd1f3
Compare
product-auto-label
bot
added
size: s
|
Warning: This pull request is touching the following templated files:
|
punya
force-pushed
the
fix-promise-patching
branch
from
87dd1f3
to
7990e05
Compare
product-auto-label
bot
added
size: xs
gcf-owl-bot
bot
removed
the
owlbot:run
aabmass
approved these changes
Aug 29, 2022
This ensures that asynchronous work done by patching gets awaited properly. In particular, it prevents unhandled promise rejections. Fixes googleapis#1319.
punya
force-pushed
the
fix-promise-patching
branch
from
4cac9d1
to
7a3ec29
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 29, 2022
🤖 I have created a release *beep* *boop* --- ## [7.1.1](v7.1.0...v7.1.1) (2022-08-29) ### Bug Fixes * **pg:** Return patched promise instead of original ([#1470](#1470)) ([e79407e](e79407e)) * **redis:** Apply instrumentation only for Redis <4.0 ([b75f5d8](b75f5d8)) * remove pip install statements ([#1546](#1546)) ([#1468](#1468)) ([fbcc88c](fbcc88c)) * Remove unused type arg ([#1467](#1467)) ([ed422ed](ed422ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1319