-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pg 7.x #701
Conversation
@matt-oakes Thanks for the PR! Mind if I rebase + commit to your |
@kjin No problem at all! |
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
- Coverage 91.02% 90.87% -0.16%
==========================================
Files 29 29
Lines 1437 1435 -2
Branches 280 280
==========================================
- Hits 1308 1304 -4
Misses 52 52
- Partials 77 79 +2
Continue to review full report at Codecov.
|
@matt-oakes The upgrade guide for PG 7 suggests that there are some API changes that aren't covered in the current plugin implementation. Would you be interested in amending your PR to support these API changes? If not -- that's totally fine, I'll merge this PR and open a new one imminently to support those changes. (I've gone through the upgrade guide just now so I think I have a pretty good idea of what needs to be changed.) |
@kjin Would it be possible for you to do it. I haven't got too much experience with either this module or the Thanks! |
Sure thing. I'll go ahead an merge this PR then! |
No description provided.