Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hapi 17 tracing support #710

Merged
merged 3 commits into from
Apr 3, 2018
Merged

feat: hapi 17 tracing support #710

merged 3 commits into from
Apr 3, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Apr 2, 2018 •
edited
Loading

This PR adds support for tracing Hapi 17. GCLOUD_TRACE_NEW_CONTEXT must be set.

Fixes #601

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2018
@kjin kjin force-pushed the plugin-types-ex branch 3 times, most recently from 092bb6b to 4ad8993 Compare April 2, 2018 16:56
@kjin kjin mentioned this pull request Apr 2, 2018
Merged
@kjin kjin force-pushed the plugin-types-ex branch 2 times, most recently from 1ccaba2 to 96d9e80 Compare April 3, 2018 01:03
@codecov
Copy link

codecov bot commented Apr 3, 2018 •
edited
Loading

Codecov Report

Merging #710 into master will decrease coverage by 0.09%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #710     +/-   ##
=========================================
- Coverage   90.78%   90.68%   -0.1%     
=========================================
  Files          29       29             
  Lines        1486     1492      +6     
  Branches      293      294      +1     
=========================================
+ Hits         1349     1353      +4     
- Misses         57       59      +2     
  Partials       80       80
Impacted Files Coverage Δ
src/plugins/plugin-hapi.ts 88.67% <91.3%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b646611...20cb632. Read the comment docs.

jinwoo
jinwoo approved these changes Apr 3, 2018
View reviewed changes
src/plugins/plugin-hapi.ts Outdated
type Hapi16Module = typeof hapi_16;
type Hapi17RequestExecutePrivate = {
(this: hapi_17.Request): Promise<void>;
[ORIGINAL]?: Hapi17RequestExecutePrivate;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/plugins/plugin-hapi.ts Outdated
{
versions: '8 - 16',
patch(hapi, api) {
function createMiddleware(): hapi_16.ServerExtRequestHandler {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@kjin kjin merged commit 028032f into googleapis:master Apr 3, 2018
@BenCrux
Copy link

BenCrux commented Apr 3, 2018

This is great @kjin - any idea when this would become a version we'd be able to pull down and use?

@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinwoo jinwoo jinwoo approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjin @BenCrux @jinwoo @googlebot