Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement (de)serialization of binary trace context as utils #812

Merged
merged 4 commits into from
Jul 18, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jul 18, 2018

These functions will be used by gRPC tracing to (de)serialize binary trace context.

Because JS doesn't support the full range of 64-bit numbers, I've added a dependency on hex2dec which allows us to convert from arbitrary-length hex to decimal strings and vice-versa.

@kjin kjin requested a review from a team July 18, 2018 01:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2018
src/util.ts Outdated
// 18 spanID field ID (1)
// 19->26 spanID value (traceContext.spanID)
// 27 options field ID (2)
// 28 options value (traceContext.options)

This comment was marked as spam.

@kjin kjin changed the title refactor: implement (de)serialization of binary trace context as utils feat: implement (de)serialization of binary trace context as utils Jul 18, 2018
@kjin kjin merged commit f96c827 into googleapis:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants