Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use small HTTP dependency #858

Merged
merged 1 commit into from
Sep 18, 2018
Merged

feat: use small HTTP dependency #858

merged 1 commit into from
Sep 18, 2018

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Sep 8, 2018

Use teenyRequest instead of request. This saves 900 ms at
startup time.

Improve load time from 1500 ms to 650 ms.

Before request:
screen shot 2018-09-07 at 9 27 55 pm

After with teenyRequest:
screen shot 2018-09-07 at 9 28 52 pm

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2018
@fhinkel fhinkel mentioned this pull request Sep 11, 2018
Closed
@kjin
Copy link
Contributor

kjin commented Sep 13, 2018

There is a problem where teeny-request expects its body input to be an object, while request expects it to be a string. We exhibit the latter behavior currently, so this PR fails system tests. I'm currently trying to fix it.

@fhinkel
Copy link
Contributor Author

fhinkel commented Sep 14, 2018

Thanks, PRs to teeny are welcome! I had accidentally stringified a string, but fixed that in 3.8.

@fhinkel
Copy link
Contributor Author

fhinkel commented Sep 17, 2018

ping @kjin

@kjin
Copy link
Contributor

kjin commented Sep 17, 2018 •
edited
Loading

@fhinkel Oh, I didn't know you were the author of teeny-request 😆 I'll open a PR if you haven't fixed that already.

@kjin kjin mentioned this pull request Sep 17, 2018
Merged
@fhinkel
feat: use small HTTP dependency
19cbbca 
Use teenyRequest instead of request. This saves 900 ms at
startup time.
@ghost ghost assigned fhinkel Sep 18, 2018
@fhinkel fhinkel merged commit 210dc3f into master Sep 18, 2018
@fhinkel fhinkel deleted the withTeeny branch September 18, 2018 01:46
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees

@fhinkel fhinkel

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fhinkel @kjin @JustinBeckwith @googlebot