feat: support context propagation in bluebird #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
assigned
Closed
ofrobots
reviewed
Sep 28, 2018
kjin
force-pushed
the
bluebird-patch
branch
from
bcf2603
to
a1bd792
Compare
|
👋 @googleapis/node-team @kjin this is gettin a little moldy. Are we moving forward with this PR? |
kjin
changed the title
kjin
force-pushed
the
bluebird-patch
branch
2 times, most recently
from
e00ec40
to
439956e
Compare
|
@googleapis/node-team This is ready for another look. Note that the knex plugin has now been removed, it seems to be superfluous. |
ofrobots
reviewed
Feb 16, 2019
| description: 'immediate resolve + child from then callback', | ||
| makePromise: () => new BPromise(res => res()), | ||
| thenFn: (p, cb) => p.then(cb) | ||
| } as TestCase, |
There was a problem hiding this comment.
why is this cast needed here and elsewhere?
There was a problem hiding this comment.
It's a TypeScript limitation, there's no other way to make each individual TestCase object self-consistent (TS doesn't know that the return type of makePromise should be the same as the input for thenFn)
ofrobots
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for context propagation across bluebird Promises. (Edit: it also removed the knex plugin, which seems to be rendered superfluous by the bluebird plugin)