Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling rate too high #894

Closed
andzdroid opened this issue Oct 25, 2018 · 2 comments
Closed

Sampling rate too high #894

andzdroid opened this issue Oct 25, 2018 · 2 comments
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. in progress priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@andzdroid
Copy link

The sampling rate is limited to minimum 1 per second, but this is still too high.

I would like to be able to specify for example 1 per 10 seconds, or even just a percentage like 0.1%.
@kjin kjin self-assigned this Oct 25, 2018
@kjin kjin added in progress priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 25, 2018
This was referenced Oct 25, 2018
Merged
Merged
@kjin kjin closed this as completed in #896 Oct 29, 2018
@kjin
Copy link
Contributor

kjin commented Nov 2, 2018

Hi @andzdroid -- we've fixed this in 3.3.0. Please let us know if there are additional issues that need to be addressed!

@andzdroid
Copy link
Author

Thanks!

@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. in progress priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andzdroid @kjin