fix(storage): add methods to s4 non idempotent operations (#56)

* fix: add storage retry conf test schema scenario 4 * update retry conf tests s3 instruction cases * revise order alphabetically
googleapis · Sep 7, 2021 · 0fe5931 · 0fe5931
1 parent 64c08de
commit 0fe5931
Showing 1 changed file with 20 additions and 6 deletions.
diff --git a/storage/v1/retry_tests.json b/storage/v1/retry_tests.json
@@ -76,13 +76,10 @@
       "description": "conditionally_idempotent_no_retries_when_precondition_is_absent",
       "cases": [
         {
-          "instructions": ["return-503", "return-503"]
+          "instructions": ["return-503"]
         },
         {
-          "instructions": ["return-reset-connection", "return-reset-connection"]
-        },
-        {
-          "instructions": ["return-reset-connection", "return-503"]
+          "instructions": ["return-reset-connection"]
         }
       ],
       "methods": [
@@ -106,10 +103,27 @@
       "description": "non_idempotent",
       "cases": [
         {
-          "instructions": []
+          "instructions": ["return-503"]
+        },
+        {
+          "instructions": ["return-reset-connection"]
         }
       ],
       "methods": [
+        {"name": "storage.bucket_acl.delete",             "resources": ["BUCKET"]},
+        {"name": "storage.bucket_acl.insert",             "resources": ["BUCKET"]},
+        {"name": "storage.bucket_acl.patch",              "resources": ["BUCKET"]},
+        {"name": "storage.bucket_acl.update",             "resources": ["BUCKET"]},
+        {"name": "storage.default_object_acl.delete",     "resources": ["BUCKET"]},
+        {"name": "storage.default_object_acl.insert",     "resources": ["BUCKET"]},
+        {"name": "storage.default_object_acl.patch",      "resources": ["BUCKET"]},
+        {"name": "storage.default_object_acl.update",     "resources": ["BUCKET"]},
+        {"name": "storage.hmacKey.create",                "resources": []},
+        {"name": "storage.notifications.insert",          "resources": ["BUCKET"]},
+        {"name": "storage.object_acl.delete",             "resources": ["BUCKET", "OBJECT"]},
+        {"name": "storage.object_acl.insert",             "resources": ["BUCKET", "OBJECT"]},
+        {"name": "storage.object_acl.patch",              "resources": ["BUCKET", "OBJECT"]},
+        {"name": "storage.object_acl.update",             "resources": ["BUCKET", "OBJECT"]}
       ],
       "preconditionProvided": false,
       "expectSuccess": false