fix: Remove HttpMethod compile time dependency from genrated HttpJson stubs #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neenu1995
approved these changes
Jun 14, 2022
|
Kudos, SonarCloud Quality Gate passed! |
blakeli0
reviewed
Jun 14, 2022
| @@ -14,7 +14,6 @@ | |||
|
|
|||
| package com.google.api.generator.gapic.composer.rest; | |||
|
|
|||
| import com.google.api.client.http.HttpMethods; | |||
There was a problem hiding this comment.
Just wondering what's the benefit of removing the dependency of this class? I think we still need the http client library so we can not remove the dependency entirely in gax?
There was a problem hiding this comment.
The REGAPIC files were adding an additional dependency on google-http-client in the downstream GAPIC libraries. This fix avoids that.
http-client is a legacy library we don't want in our GAPIC dependency tree.
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.